Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client 7784 AMD support restore #300

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

symunona
Copy link

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [ X ] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

A description of what this PR does.
#188
Log lib scoping issue broke the build on AMD. Fixed by adding the lib to the repo with the fix from twilio-video, inspiration: https://github.com/twilio/twilio-video.js/pull/1352/files

Tests
Looks like on the master branch there are a couple of broken files I did not touch, linter throws error on those, so testing failed but I am fairly confident the fix works, since I imported the built lib into our AMD system and it does not bail as before.

I did not add the unit tests, that looked a bit more complex.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • [ X ] Verified locally with npm test
  • [ X ] Manually sanity tested running locally
  • [ X ] Ready for review

Before merge

  • Got one or more +1s
  • Squashed erroneous commits if necessary
  • Re-tested if necessary

@symunona
Copy link
Author

NOTE: I had to build to test it, I am not familiar with your pipeline, but Jeremy found that some of the generated files contain hard links to our repo.

Probably you'll need to cherry pick the first commit into a new PR and I assume your CI will take care of it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant