Refactored test_build.py #565

mdellweg · 2023-11-07T16:13:56Z

Made use of more generic with_[git_]project decorators.

Description

Checklist

Make sure changes are covered by existing or new tests.
For at least one Python version, make sure local test run is green.
Create a file in src/towncrier/newsfragments/. Describe your
change and include important information. Your change will be included in the public release notes.
Make sure all GitHub Actions checks are green (they are automatically checking all of the above).
Ensure docs/tutorial.rst is still up-to-date.
If you add new CLI arguments (or change the meaning of existing ones), make sure docs/cli.rst reflects those changes.
If you add new configuration options (or change the meaning of existing ones), make sure docs/configuration.rst reflects those changes.

src/towncrier/test/helpers.py

adiroiban

Looks good. Only minor comments. Much appreciated.

I did a quick review between a meeting and a windows server core image build :)

adiroiban · 2023-11-08T14:49:24Z

src/towncrier/test/test_build.py

-                f.write("**Blah blah**")
-
-            result = runner.invoke(command, ["--draft", "--date", "01-01-2001"])
+    @with_project()


happy to see the reduction in code indentation/nesting :)

adiroiban · 2023-11-08T14:49:43Z

src/towncrier/test/test_build.py

@@ -157,7 +152,12 @@ def test_in_different_dir_config_option(self, runner):
        self.assertEqual(0, result.exit_code)
        self.assertTrue((project_dir / "NEWS.rst").exists())

-    @with_isolated_runner
+    @with_project(


this is so much easier to read. thanks a lot!

adiroiban · 2023-11-08T15:16:02Z

src/towncrier/test/test_build.py

-            """
-foo 7.8.9 (01-01-2001)
-======================
+            dedent(


just asking. Was this change needed? was the test failing with the old code?

For assertion, I prefer to have as little processing as possible.

But we can also have this code... no problem.

Not specifically needed. But this way it aligns better with the other tests doing assertions the same way.

Ok. We can merge this. No problem.

Made use of more generic with_[git_]project decorators. Co-authored-by: Adi Roiban <[email protected]>

for more information, see https://pre-commit.ci

adiroiban · 2023-11-09T12:37:15Z

It looks good. I don't have time to look into the details... but I think that we are fine.
It's better than we have in trunk, the tests pass, so it shoudl be good to merge... the bar is low, I know, but this is what we can do now.

mdellweg force-pushed the refactor_build_tests branch 3 times, most recently from a7820ac to 875df57 Compare November 8, 2023 09:05

adiroiban reviewed Nov 8, 2023

View reviewed changes

src/towncrier/test/helpers.py Outdated Show resolved Hide resolved

adiroiban approved these changes Nov 8, 2023

View reviewed changes

Refactored test_build.py

3cddf1d

Made use of more generic with_[git_]project decorators. Co-authored-by: Adi Roiban <[email protected]>

mdellweg force-pushed the refactor_build_tests branch from dabcb3e to 3cddf1d Compare November 9, 2023 10:19

[pre-commit.ci] auto fixes from pre-commit.com hooks

4f82e49

for more information, see https://pre-commit.ci

mdellweg marked this pull request as ready for review November 9, 2023 10:23

mdellweg requested a review from a team as a code owner November 9, 2023 10:23

adiroiban merged commit d871ea3 into twisted:trunk Nov 9, 2023
13 checks passed

mdellweg deleted the refactor_build_tests branch November 9, 2023 12:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactored test_build.py #565

Refactored test_build.py #565

mdellweg commented Nov 7, 2023

adiroiban left a comment •

edited

Loading

adiroiban Nov 8, 2023

adiroiban Nov 8, 2023

adiroiban Nov 8, 2023 •

edited

Loading

mdellweg Nov 9, 2023

adiroiban Nov 9, 2023

adiroiban commented Nov 9, 2023

Refactored test_build.py #565

Refactored test_build.py #565

Conversation

mdellweg commented Nov 7, 2023

Description

Checklist

adiroiban left a comment • edited Loading

Choose a reason for hiding this comment

adiroiban Nov 8, 2023

Choose a reason for hiding this comment

adiroiban Nov 8, 2023

Choose a reason for hiding this comment

adiroiban Nov 8, 2023 • edited Loading

Choose a reason for hiding this comment

mdellweg Nov 9, 2023

Choose a reason for hiding this comment

adiroiban Nov 9, 2023

Choose a reason for hiding this comment

adiroiban commented Nov 9, 2023

adiroiban left a comment •

edited

Loading

adiroiban Nov 8, 2023 •

edited

Loading