Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split event message id #322

Merged
merged 7 commits into from
Jun 18, 2024
Merged

Conversation

SputNikPlop
Copy link
Contributor

@SputNikPlop SputNikPlop commented Apr 10, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

This is addressing #184 since the cli doesn't match quite what is being used on the twitch website.

Description of Changes:

  • Split event and subscription id

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@SputNikPlop SputNikPlop marked this pull request as ready for review April 11, 2024 16:03
@Xemdo Xemdo self-requested a review June 7, 2024 16:38
@Xemdo Xemdo merged commit 30cf222 into twitchdev:main Jun 18, 2024
4 checks passed
@SputNikPlop SputNikPlop deleted the event-message-id branch June 18, 2024 04:40
BarryCarlyon added a commit to BarryCarlyon/twitch-cli that referenced this pull request Jul 2, 2024
Testing verify trigger and retrigger (on the raid topic at least)

Notable faults/issues

Random ID usage on CP Reward add and TRN Event, this probably needs to be lifted to a field (seperate PR?)
@BarryCarlyon BarryCarlyon mentioned this pull request Jul 2, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants