Check LZO index file existence when check splitability of LZO files #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dvryaboy
reviewed
Dec 29, 2017
| @@ -29,6 +29,10 @@ | |||
| <groupId>com.twitter.elephantbird</groupId> | |||
| <artifactId>elephant-bird-core</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>com.hadoop.gplcompression</groupId> | |||
There was a problem hiding this comment.
folks, this is not an apache license compatible package.
EB needs to clean up these dependencies, adding more of them makes the problem worse.
Making this class explicitly aware of one specific type of file extension seems pretty brute-force. This whole thing is a wrapper -- is there a way to delegate to underlying machinery to determine if the wrapped InputFormat is splittable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.