Skip to content

java 11 reflect warning fixes #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sjoerd-vogel wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

java 11 reflect warning fixes #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 31 additions & 17 deletions util-jvm/src/main/scala/com/twitter/jvm/Hotspot.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,18 @@ class Hotspot extends Jvm {
ObjectName.getInstance("com.sun.management:type=HotSpotDiagnostic")

private[this] val jvm: VMManagement = {
val fld = Class
.forName("sun.management.ManagementFactoryHelper")
.getDeclaredField("jvm")
fld.setAccessible(true)
fld.get(null).asInstanceOf[VMManagement]
try {
sun.management.ManagementFactoryHelper
.getVMManagement
.asInstanceOf[VMManagement]
} catch {
case _: NoSuchMethodError => {
val fld = Class.forName("sun.management.ManagementFactoryHelper")
.getDeclaredField("jvm")
fld.setAccessible(true)
fld.get(null).asInstanceOf[VMManagement]
}
}
}

private[this] def opt(name: String) =
Expand Down Expand Up @@ -150,7 +157,7 @@ class Hotspot extends Jvm {
)
}

private[this] object NilSafepointBean {
private[this] object NilSafepointBean extends SafepointBean {
def getSafepointSyncTime = 0L
def getTotalSafepointTime = 0L
def getSafepointCount = 0L
Expand All @@ -159,18 +166,19 @@ class Hotspot extends Jvm {
private val log = Logger.getLogger(getClass.getName)

private[this] val safepointBean = {
val runtimeBean = Class
.forName("sun.management.ManagementFactoryHelper")
.getMethod("getHotspotRuntimeMBean")
.invoke(null)

def asSafepointBean(x: AnyRef) = {
x.asInstanceOf[{
def getSafepointSyncTime: Long
def getTotalSafepointTime: Long
def getSafepointCount: Long
}]
val runtimeBean = sun.management.ManagementFactoryHelper.getHotspotRuntimeMBean

def asSafepointBean(x: AnyRef): SafepointBean = x match {

case h: sun.management.HotspotRuntimeMBean => new SafepointBean() {
override def getSafepointCount: Long = h.getSafepointCount
override def getSafepointSyncTime: Long = h.getSafepointSyncTime
override def getTotalSafepointTime: Long = h.getTotalSafepointTime
}

case a => a.asInstanceOf[SafepointBean]
}

try {
asSafepointBean(runtimeBean)
} catch {
Expand All @@ -181,6 +189,12 @@ class Hotspot extends Jvm {
}
}

private[this] trait SafepointBean {
def getSafepointSyncTime : Long
def getTotalSafepointTime : Long
def getSafepointCount : Long
}

def safepoint: Safepoint = {
val syncTime = safepointBean.getSafepointSyncTime
val totalTime = safepointBean.getTotalSafepointTime
Expand Down