Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitpod fixes #148

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Gitpod fixes #148

wants to merge 4 commits into from

Conversation

stackerdude
Copy link
Collaborator

This PR fixes issues that are cause by moving to GitPod(GP). Currently no way of getting hot module replacement to work as i cant figure out away to map the ephemeral port. Other the this this PR addresses

  • Upgrading and pinning the base docker image (node:11.10.1-alpine)
  • Adding a debug runner of Jest. This will allow them to debug failing test
  • Note enforcing host validation (this was actually done on commit 1c706b1)

Still need to discuss what is happening with other levels ups before merging to master.

This allows us to pin the base docker image so we aren't effected by
changes that gitpod make.
This allows for breakpoint to be set within the test (spec) files.
Should make debugging easier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant