MSP-6561 add requestId#6
Merged
Merged
Conversation
d1slike
reviewed
Oct 24, 2025
d1slike
reviewed
Oct 24, 2025
d1slike
reviewed
Oct 24, 2025
d1slike
reviewed
Oct 24, 2025
d1slike
left a comment
d1slike
left a comment
Contributor
There was a problem hiding this comment.
func NewPgStore(db *sql.DB) *pgStore
Вот тут предлагаю сломать обратную совместимость, переименовав конструктор в NewPgStoreV2 та как новая реализация не может работать со старой схемой, а также думаю стоит добавить проверку на существование колонки в таблице, если ее нет, возвращать ошибку с рекомендацией добавить миграцию.
Все это делается для того что бы мы случайно обновили библиотеку, у нас все сломалось на этапе компиляции и отладку проекта.
d1slike
reviewed
Oct 27, 2025
d1slike
reviewed
Oct 27, 2025
added 2 commits
October 27, 2025 17:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.