Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] AddressByStake reducer #117

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] AddressByStake reducer #117

wants to merge 2 commits into from

Conversation

Mercurial
Copy link

@Mercurial Mercurial commented Nov 24, 2022 •
edited
Loading

image

@matiwinnetou
Copy link
Collaborator

This is great but please consider also support for addresses in hex format. You can see examples in CRFA branch.

@rvcas
Copy link
Member

rvcas commented Nov 24, 2022 •
edited
Loading

@matiwinnetou would that be a separate reducer or a projection on the one reducer? when you say hex do you mean the raw cbor bytes?

@matiwinnetou
Copy link
Collaborator

matiwinnetou commented Nov 24, 2022 •
edited
Loading

I solved this as simply a configuration parameter for an existing reducer. When I mean HEX I mean HEX projection of cardano address. pallas-address has toHex functions.

@matiwinnetou
Copy link
Collaborator

@Mercurial What is the status of this, can this be finished and merged in please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scarmuega scarmuega Awaiting requested review from scarmuega scarmuega will be requested when the pull request is marked ready for review scarmuega is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mercurial @matiwinnetou @rvcas