Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify python interpreter when installing pip dependencies for CI #656

Open
wants to merge 10 commits into
base: development
Choose a base branch
from

Conversation

krishnangovindraj
Copy link
Member

Usage and product changes

We now specify the python interpreter when installing pip dependencies for CI. This allows us to ensure the dependencies are installed for the specified toolchain.

Implementation

Introduce a python_interpreter_symlink repository which resolves toolchain based on information from repository_context.os. The symlink for the right version can then be passed to pip_parse as the python_interpreter_target argument.

@typedb-bot
Copy link
Member

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

"""
rctx.file("WORKSPACE", "workspace(name = \"%s\")"%rctx.attr.name)
rctx.file("BUILD.bazel", content=build_file_content, executable=False)
rctx.symlink(resolved_interpreter_label, "python")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this Windows-friendly?

Comment on lines 802 to 805
apt update -y && apt install -y software-properties-common
add-apt-repository -y ppa:deadsnakes/ppa
apt update -y && apt install -y python3.9 python3.9-distutils python3-pip software-properties-common
python3.9 -m pip install -U cffi
python3.10 -m pip install -U cffi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we now remove all of these?

@krishnangovindraj krishnangovindraj force-pushed the python-interpreter-symlink-rule branch from d6f26eb to d90c666 Compare June 13, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants