-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various CE3 improvements #347
base: main
Are you sure you want to change the base?
Various CE3 improvements #347
Conversation
I've merged my branch, so you can base your PR(s) on |
02db891
to
bea885c
Compare
Cuts down on noise from the root monitor.
This works with Await for Sync: it will need to become more sophisticated to support cancellation and non-termination.
Allows using the twitter-util testing facilities.
bea885c
to
57b83f3
Compare
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
- Coverage 91.12% 90.10% -1.03%
==========================================
Files 17 17
Lines 293 293
Branches 1 1
==========================================
- Hits 267 264 -3
- Misses 26 29 +3
Continue to review full report at Codecov.
|
Hi @dangerousben do you need any help getting this merged? I have a catbird-dependent project that I'd like to upgrade to CE3 soon and I'm taking an interest in improving this project. |
@DuncanHills I don't have time to review this but if you could do a quick review I'd be happy to merge this in. I honestly lost track of it, sorry @dangerousben |
Main changes:
SyncGenerators
provided by the CE3 testkit to generate interestingRerunnable
instancesunsafeRun
(just usingAwait
for now)Time
andStopwatch
for theClock
methodsDivided up into small commits so should be easy enough to pull out anything that's contentious.
@felixbr this could go in before or after #267, I'm not sure what that's currently waiting on?