Use global counter as an MBean ID for WSTP #4186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRevive
commented
Nov 27, 2024
| try { | ||
| val localQueueSamplerName = new ObjectName( | ||
| s"cats.effect.unsafe.metrics:type=LocalQueueSampler-$hash-$i") | ||
| s"cats.effect.unsafe.metrics:type=LocalQueueSampler-$threadPoolId-$i") |
Contributor
Author
There was a problem hiding this comment.
Unlike #3813, there is no global counter for queues. Pool ID + queue index should be a unique combination.
iRevive
force-pushed
the
metrics-pool-id
branch
from
e246f7d to
bb172dd
Compare
djspiewak
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cherry-picked the ID idea from #3813 since it was pushed to 3.7.
It should be easier to use with MBeans and metrics, too.