Reprioritize UUIDGen.fromSecureRandom to avoid ambiguity on Scala 2.12 #4398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djspiewak
requested changes
Sep 1, 2025
|
|
||
| import java.util.UUID | ||
|
|
||
| object ImplicitPriorityPlayground { |
There was a problem hiding this comment.
Generally the way that we've done this in the past is to structure compilation tests as actual test suites with a tautological tests (i.e. the test always passes at runtime provided it compiles). MUnit doesn't provide anything more elaborate than that, sadly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4397.
The way the diff is presented is a little misleading; I moved
fromSecureRandominto its own trait, but it looks like I movedTranslatedUUIDGenaround. (Which isn't wrong, just not as useful of a way to think about it IMO.)I'm expecting bike-shedding on
ImplicitPriorityPlayground, at least, which is why I marked this as a draft PR for now.