-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fastparse to 3.0.2 #519
Conversation
@@ -121,6 +121,7 @@ lazy val bench = project | |||
.settings( | |||
name := "bench", | |||
coverageEnabled := false, | |||
scalacOptions += "-Wconf:cat=unused-nowarn:s", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suppresses this only for bench
project
[error] /home/runner/work/cats-parse/cats-parse/bench/src/main/scala/cats/parse/bench/fastparse.scala:50:43: @nowarn annotation does not suppress any warnings
[error] P(space ~ "\"" ~/ (strChars | escape).rep.! ~ "\"").map(JString.apply)
[error] ^
[error] one error found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @johnynek any concerns about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No concern for bench.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
==========================================
- Coverage 95.13% 95.06% -0.07%
==========================================
Files 10 10
Lines 1480 1480
Branches 330 330
==========================================
- Hits 1408 1407 -1
- Misses 72 73 +1 β View full report in Codecov by Sentry. |
About this PR
π¦ Updates com.lihaoyi:fastparse from
2.3.3
to3.0.2
βπ GitHub Release Notes - Version Diff
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
β Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: