Update to sbt-typelevel 0.5.0-RC11 #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Aug 9, 2023
| val q = (p1 ~ p2) | p2 | ||
| val q = (p1 ~ p2).void | p2.void |
There was a problem hiding this comment.
New compiler warning when it infers Any as in Parser[Any] as a "probable bug".
Comment on lines
+46
to
49
| val ok = string("ok").void | ||
| val nl = string("\n") | ||
| val lx = string("l") ~ digits | ||
| val lx = (string("l") ~ digits).void | ||
| val lxOk = ((lx | ok) ~ nl) |
There was a problem hiding this comment.
Same here. Specifically it's affecting the | combinator.
johnynek
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to sbt-typelevel 0.5.0 series. Staying in RC phase while upgrading Typelevel projects to iron out any issues, but is otherwise stable.
For how much longer is the plan to keep building for Scala 2.11? I was able to make things work but it was mildly annoying.