Move Ordering implicit into else

typelevel · Feb 1, 2025 · 19f2d92 · 19f2d92
1 parent b02647f
commit 19f2d92
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/core/src/main/scala/cats/data/NonEmptyList.scala b/core/src/main/scala/cats/data/NonEmptyList.scala
@@ -343,10 +343,10 @@ final case class NonEmptyList[+A](head: A, tail: List[A]) extends NonEmptyCollec
   override def distinct[AA >: A](implicit O: Order[AA]): NonEmptyList[AA] = distinctBy(identity[AA])
 
   override def distinctBy[B](f: A => B)(implicit O: Order[B]): NonEmptyList[A] = {
-    implicit val ord: Ordering[B] = O.toOrdering
-
     if (tail.isEmpty) this
     else {
+      implicit val ord: Ordering[B] = O.toOrdering
+
       val bldr = List.newBuilder[A]
       val seen = mutable.TreeSet.empty[B]
       var rest = tail

diff --git a/core/src/main/scala/cats/data/NonEmptySeq.scala b/core/src/main/scala/cats/data/NonEmptySeq.scala
@@ -239,10 +239,10 @@ final class NonEmptySeq[+A] private (val toSeq: Seq[A]) extends AnyVal with NonE
   override def distinct[AA >: A](implicit O: Order[AA]): NonEmptySeq[AA] = distinctBy(identity[AA])
 
   override def distinctBy[B](f: A => B)(implicit O: Order[B]): NonEmptySeq[A] = {
-    implicit val ord: Ordering[B] = O.toOrdering
-
     if (toSeq.lengthCompare(1) == 0) this
     else {
+      implicit val ord: Ordering[B] = O.toOrdering
+
       val bldr = Seq.newBuilder[A]
       val seen = mutable.TreeSet.empty[B]
       val it = iterator

diff --git a/core/src/main/scala/cats/data/NonEmptyVector.scala b/core/src/main/scala/cats/data/NonEmptyVector.scala
@@ -249,10 +249,10 @@ final class NonEmptyVector[+A] private (val toVector: Vector[A])
   override def distinct[AA >: A](implicit O: Order[AA]): NonEmptyVector[AA] = distinctBy(identity[AA])
 
   override def distinctBy[B](f: A => B)(implicit O: Order[B]): NonEmptyVector[A] = {
-    implicit val ord: Ordering[B] = O.toOrdering
-
     if (toVector.lengthCompare(1) == 0) this
     else {
+      implicit val ord: Ordering[B] = O.toOrdering
+
       val bldr = Vector.newBuilder[A]
       val seen = mutable.TreeSet.empty[B]
       val it = iterator