Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalafmt-core to 3.8.3 #589

Closed
wants to merge 1 commit into from

Conversation

typelevel-steward[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates org.scalameta:scalafmt-core from 3.8.2 to 3.8.3

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
}]
labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

@satorg
Copy link
Contributor

satorg commented Jul 31, 2024

Since this update is known to be buggy. I would suggest to skip it even though it does not affect this repository specifically.
I'm going close it shortly unless there are any objections.

@TonioGela
Copy link
Member

Since this update is known to be buggy. I would suggest to skip it even though it does not affect this repository specifically. I'm going close it shortly unless there are any objections.

I wasn't aware of this and I might have merged a couple of these PRs on other projects.

this update is known to be buggy.

Do you have something to read about this?

@satorg
Copy link
Contributor

satorg commented Aug 10, 2024

@TonioGela ,
This scalafmt version makes CI in Cats failing: typelevel/cats#4640
but in very particular cases only.

In fact, there were some other projects affected too, I cannot remember which ones exactly.

I wasn't aware of this and I might have merged a couple of these PRs on other projects.

I did too 🀷 It should not be a big issue util someone adds a new feature that brings a new code that scalafmt will start rewriting incorrectly. So I think, no worries at this point.

@TonioGela TonioGela closed this Sep 16, 2024
@typelevel-steward typelevel-steward bot deleted the update/scalafmt-core-3.8.3 branch September 16, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants