Add tests for validity of standardized variation sequences #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MDLC01
added
the
waiting on reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the testing infrastructure to also test that standardized variation sequences are valid. I also reorganized
build.rsto separate the processing of Codex module files from the part that downloads Unicode data files for the tests.Standardized variation sequences are defined by Unicode in
standardized-variation-sequences.txtand are sequences consisting of an initial character and a variation selector from VS1 to vS14. Notably, standardized variation sequences are disjoint from emoji variation sequences (i.e., presentation sequences), which we already fully support since #114.Unicode defines a third kind of variation sequences: ideographic variation sequences, which we do not care about in Codex.
More on variation sequences: https://www.unicode.org/versions/Unicode17.0.0/core-spec/chapter-23/#G26678.