Make archiver tests read-only by default #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #202, also previously mentioned here #176 (comment)
This change ensures running archiver tests won't update existing archive files unless the env var
HAYAGRIVA_ARCHIVER_UPDATE=1is specified. By default, the tests will only check if the files are up-to-date, aborting (and suggesting specifyingHAYAGRIVA_ARCHIVER_UPDATE=1) if not.Currently, CI won't detect missing changes to the archive, as the files would just be updated on each CI run (which doesn't matter since the filesystem in CI is ephemeral).
The idea for future PRs is to not check for archive changes in CI anyway to keep it immutable. Rather, we'd have a recurring (perhaps weekly) check to ensure things are up-to-date, and then manually update the files as needed.