Merge branch 'master' of github.com:turingschool/ruby-submissions

1409/01_mastermind/mastermind_submissions.yml

@@ -29,40 +29,58 @@ submissions:
       Breaking Logic into Components: 2.5
   Sam Kuhlmann:
     repository: https://github.com/skuhlmann/turing_mastermind
-    notes: ""
+    notes: "Showed effort toward good organization and refactoring.
+            Saw use of each_with_index, map, count for enumerables.
+            Small classes well-tested, but missing tests for game logic.
+            Some rough edges in game play (not major features), but clear and pleasant to play otherwise.
+            Broke out responsibilities into small classes (timer, code generator, message printer, etc.), but game class could be smaller."
     evaluation:
-      Fundamental Ruby & Style: 0
-      Enumerable & Collections: 0
-      Test-Driven Development: 0
-      REPL Interface: 0
-      Breaking Logic into Components: 0
+      Fundamental Ruby & Style: 3
+      Enumerable & Collections: 3
+      Test-Driven Development: 2.5
+      REPL Interface: 2.5
+      Breaking Logic into Components: 3
   Gregory Narajka:
-    repository:
-    notes: ""
-    evaluation:
-      Fundamental Ruby & Style: 0
-      Enumerable & Collections: 0
-      Test-Driven Development: 0
-      REPL Interface: 0
-      Breaking Logic into Components: 0
+    repository: https://github.com/gregnar/mastermind.git
+    notes: "Saw good naming conventions; some long methods with nested loops/case/until statements.
+            Saw map, each_with_index, count; check use of destructive .map! and chaining each_with_index and count together.
+            Good use of StringIO for testing input/output. Well-tested in isolation and integration.
+            Game is easy and pleasant to use; implemented turns and difficulty options.
+            Encapsulated responsibilities into separate objects (printer, checker, cli, game, sequence generator, color sequence), but would like to see less logic per method (especially with loops and case statements)."
+    evaluation:
+      Fundamental Ruby & Style: 2.5
+      Enumerable & Collections: 3
+      Test-Driven Development: 4
+      REPL Interface: 4
+      Breaking Logic into Components: 3
   Kate Lane:
-    repository:
-    notes: ""
+    repository: https://github.com/katelane/mastermind.git
+    notes: "Good naming conventions; shows effort toward organization and refactoring.
+            Saw each_with_index and count -- and chained together! :)
+            Well-tested with guess checker, but missing tests on game, board, and printer.
+            Couldn't find edge-cases to break REPL. Pleasant to use.
+            Able to pull board and game apart easily; would like to see case statements pulled out from within methods."
     evaluation:
-      Fundamental Ruby & Style: 0
-      Enumerable & Collections: 0
-      Test-Driven Development: 0
-      REPL Interface: 0
-      Breaking Logic into Components: 0
+      Fundamental Ruby & Style: 3
+      Enumerable & Collections: 3
+      Test-Driven Development: 2
+      REPL Interface: 3
+      Breaking Logic into Components: 3
   Timothy Mee:
     repository: https://github.com/Tmee/MASTERMIND/tree/take_2
-    notes: "and that's that."
+    notes: "and that's that.
+            Some methods clean and single-responsibility; others need refactoring.
+            Saw use of each to iterate. Would like to see enumerables used in place of stacked if statements.
+            Attempt at testing to get user input but not implemented.
+            REPL easy to use; clear and easy to play.
+            Broke apart printer, CLI, and game (run), but Run class included a lot of responsibilities.  
+            "
     evaluation:
-      Fundamental Ruby & Style: 0
-      Enumerable & Collections: 0
-      Test-Driven Development: 0
-      REPL Interface: 0
-      Breaking Logic into Components: 0
+      Fundamental Ruby & Style: 2.5
+      Enumerable & Collections: 2
+      Test-Driven Development: 1
+      REPL Interface: 3
+      Breaking Logic into Components: 2
   Konr Larson:
     repository: https://github.com/larsonkonr/mastermind.git
     notes: "Game plays well. Good use of colors. Needs tests!!! Some weak spots