-
Notifications
You must be signed in to change notification settings - Fork 383
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed merge conflict with clone wars submissions
- Loading branch information
Showing
12 changed files
with
976 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| # NOTE: You can verify that you haven't broken the format with | ||
| # $ ruby -rpp -ryaml -e 'pp YAML.load File.read("1406/04_clone_wars/clone_wars_submissions.yml") | ||
| submissions: | ||
| Andrew Watkins, Jonmichael Chambers, Marc Garreau, Chad Brading: | ||
| repository: | ||
| setup_notes: "" | ||
| instructor_evaluation: | ||
| notes: | | ||
| Evaluated by Josh | ||
| can't log out ;p~~~~~~ | ||
| users and accounts are the same thing | ||
| nice use of presenters | ||
| Good tests in general, tiny bit not covered, but not for a particularly good reason | ||
| Can't log out, yo, sharing my cart with mah homies | ||
| no link to category | ||
| orders "all" counts current order | ||
| rubric: | ||
| Feature Completeness: 3 | ||
| Views: 4 | ||
| Controllers: 3 | ||
| Models: 4 | ||
| TDD: 4- | ||
| Usability: 3 | ||
| Horacio Chavez, Corey Davis, Tan Doan, Hilary Denton: | ||
| repository: | ||
| setup_notes: "" | ||
| instructor_evaluation: | ||
| notes: | | ||
| Evaluated by Josh | ||
| Feature Completeness | ||
| No link to my profile/orders | ||
| can see other people's orders | ||
| cart is gone forever when I logout :( | ||
| Can't edit user info | ||
| admin orders missing total | ||
| some links to transition that aren't actually available | ||
| no Heroku :P | ||
| Views | ||
| use state machine instead of logic in admin orders view | ||
| the logic that was there was wrong | ||
| correctly indent the code | ||
| find balance between the pristine pages (menu, front page) and the rest | ||
| Controllers | ||
| lots of dead code | ||
| unnecessary json stuff | ||
| session helper is better in application controller | ||
| need to push knowledge of things like `role == 'admin'` down | ||
| Models | ||
| TDD | ||
| high coverage, if you delete dead code :) | ||
| things tested at feature level that would be better at a more focused level | ||
| (e.g. I don't want to deal with the internet just to test how long a password can be) | ||
| Usability | ||
| most of the reasons are documented under features | ||
| Unused routes | ||
| most pages need aesthetic work | ||
| the map doesn't show | ||
| rubric: | ||
| Feature Completeness: 1.5 | ||
| Views: 3 | ||
| Controllers: 3 | ||
| Models: 3.5 | ||
| TDD: 3 | ||
| Usability: 2 | ||
| Emily Davis, Tim Proctor, Gustavo Villagrana, Robert Gu: | ||
| repository: [email protected]:BobGu/dinner_dash.git | ||
| setup_notes: "" | ||
| instructor_evaluation: | ||
| notes: "" | ||
| rubric: | ||
| Feature Completeness: 1 | ||
| Views: 3 | ||
| Controllers: 3.5 | ||
| Models: 4 | ||
| TDD: 2.5 | ||
| Usability: 1.5 | ||
| Allison Larson, Andy Mention, Alan Smith, Will Faurot, Eric Fransen: | ||
| repository: [email protected]:ericfransen/dinner_dash.git | ||
| setup_notes: "" | ||
| instructor_evaluation: | ||
| notes: "" | ||
| rubric: | ||
| Feature Completeness: 2.5 | ||
| Views: 3 | ||
| Controllers: 3 | ||
| Models: 4 | ||
| TDD: 4 | ||
| Usability: 4 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| Kevaah: | ||
| Feature Delivery: | ||
| * Notes | ||
| * Features and UX are very rough | ||
| * We have a lot of features that are 80% complete | ||
| * Completion: 1 | ||
| * Organization: 2 | ||
| * Progress: 3 | ||
| Technical Progress: | ||
| * Notes: | ||
| * Great work reeling in the test suite | ||
| * Some core interations are not feature tested (ie: checkout doesn't work) | ||
| * Scores: | ||
| * TDD: 3 | ||
| * Quality: 3 | ||
| * UX: 2 | ||
| EmployMe: | ||
| Feature Delivery: | ||
| * Notes | ||
| * UX shows effort but is still rough | ||
| * Some features are demoed that don't work (ie: search) | ||
| * For a text-content driven site you need better formatting of user text | ||
| * Doesn't feel like a week of progress | ||
| * Raise your standards for what it means for code to get into the app | ||
| * Scoring | ||
| * Completion: 2 | ||
| * Organization: 2 | ||
| * Progress: 3 | ||
| Technical Progress: | ||
| * Notes: | ||
| * *master* tests have a few failures | ||
| * only 35 tests | ||
| * TDD still doesn't feels important | ||
| * Scoring: | ||
| * TDD: 1 | ||
| * Quality: 3 | ||
| * UX: 2 | ||
| Airlift: | ||
| Feature Delivery: | ||
| * Notes | ||
| * Basic functionality is there | ||
| * Light UX is in place | ||
| * Features presented are implemented | ||
| * Scoring | ||
| * Completion: 3 | ||
| * Organization: 3 | ||
| * Progress: 3 | ||
| Technical | ||
| * Notes | ||
| * 130 tests that are all passing | ||
| * Scores | ||
| * TDD: 3 | ||
| * Quality: 3 | ||
| * UX: 3 | ||
| TravelHome: | ||
| Feature Delivery: | ||
| * Notes | ||
| * Some very good UX on the front and secondary pages | ||
| * Checkout flow is there and needs some refinement | ||
| * Scoring | ||
| * Completion: 3 | ||
| * Organization: 3 | ||
| * Progress: 3 | ||
| Technical: | ||
| * Notes | ||
| * 90 tests, 2 fail | ||
| * Add test coverage | ||
| * Tests are a bit brittle | ||
| * Scoring | ||
| * TDD: 2.5 | ||
| * Quality: 3? | ||
| * UX: 3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| ## TravelHome | ||
|
|
||
| ### Features & Functionality | ||
|
|
||
| #### Notes | ||
|
|
||
| * Good overall functionality | ||
| * Good job dealing with dates and JavaScript which are each challenging | ||
| * Some UX/design elements are rough, some are nice | ||
|
|
||
| #### Scores | ||
|
|
||
| * Completion: 3 | ||
| * Organization: 3 | ||
| * Progress: 3 | ||
|
|
||
| ### Technical | ||
|
|
||
| #### Notes | ||
|
|
||
| * 91 examples feels "ok" | ||
| * Add test coverage tool | ||
|
|
||
| #### Scores | ||
|
|
||
| * TDD: 3 | ||
| * Code Quality: 3 | ||
| * User Experience: 3 | ||
|
|
||
|
|
||
| ## Airlift | ||
|
|
||
| ### Features & Functionality | ||
|
|
||
| #### Notes | ||
|
|
||
| * Good functionality | ||
| * Solid UX with rough edges | ||
| * Feels like you have a lot of features | ||
| * Well executed | ||
|
|
||
| #### Scores | ||
|
|
||
| * Completion: 3 | ||
| * Organization: | ||
| * Progress: 4 | ||
|
|
||
| ### Technical | ||
|
|
||
| #### Notes | ||
|
|
||
| * 151 test, 10 pending, 141 passing | ||
| * Test structures are strong, show good refactoring | ||
|
|
||
| #### Scores | ||
|
|
||
| * TDD: 4 | ||
| * Quality: 3 | ||
| * UX: 3 | ||
|
|
||
| ## EmployMe | ||
|
|
||
| ### Features & Functionality | ||
|
|
||
| * Job browsing experience is solid | ||
| * Cart/checkout/submission a little confusing | ||
| * Design overall strong | ||
| * No resumes / no cover note is a big problem | ||
|
|
||
| #### Scores | ||
|
|
||
| * Completion: 2 | ||
| * Organization: 3 | ||
| * Progress: 2 | ||
|
|
||
| ### Technical | ||
|
|
||
| * 56 examples, 1 pending | ||
| * Controllers & models generally well put together | ||
| * Not particularly stretching technical skils | ||
| * Feature tests are generally well put together | ||
|
|
||
| #### Scores | ||
|
|
||
| * TDD: 3 | ||
| * Quality: 3 | ||
| * UX: 3 | ||
|
|
||
| ## For Next Time: | ||
|
|
||
| * Move UX to Features, Organization to Technical | ||
|
|
||
| ## Keevah | ||
|
|
||
| ### Features & Functionality | ||
|
|
||
| * UX has come a long way | ||
| * Good overall flow | ||
| * Some screens are a little rough | ||
| * Copy is much better | ||
| * Missing a platform admin kind of functionality | ||
|
|
||
| #### Scores | ||
|
|
||
| * Completion: 3 | ||
| * Organization: 3 | ||
| * Progress: 2.75 | ||
|
|
||
| ### Technical | ||
|
|
||
| * Well put together for your current skill level | ||
| * Needs some refactoring pushing logic down the stack | ||
| * Watch out for "god" objects that attract too much functionality | ||
| * Good testing | ||
| * Look for opportunities to write unit tests | ||
|
|
||
| #### Scores | ||
|
|
||
| * TDD: 3 | ||
| * Quality: 3 | ||
| * UX: 3 |
Oops, something went wrong.