crt-lottes and pixellate now use hardware linearization #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @tyrells, we have added support for sRGB textures and framebuffers for GLSL shaders in DOSBox Staging (see here). Shaders can now request these features via pragmas:
The nice thing about this is that it's completely backwards compatible -- the shader compiler will always ignore these unknown pragmas, it's a pre-processor step in DOSBox Staging that looks for them.
We are definitely planning to merge this feature back upstream into the DOSBox SVN branch.
This PR updates all shaders in your repo that benefit from proper gamma-correct interpolation. I've tried to add it to all shaders that don't do their own linearisation (like most CRT shaders), but sadly they seem to be tuned for incorrect "sRGB space" interpolation so they look quite different and basically broken when things are done in the mathematically correct way. Because of this, I've just left them alone.
If you're interested, here are our discussions with before/after screenshots about why we introduced this feature in the first place, but I'm sure you're aware of all the reasons:
dosbox-staging/dosbox-staging#1627
dosbox-staging/dosbox-staging#1634