Handle hidden field #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @register.filter | ||
| def is_hidden(field): | ||
| return field.field.widget.__class__.__name__.lower() == "hiddeninput" |
There was a problem hiding this comment.
Replace this line with "isinstance(field.field.widget, forms.HiddenInput)" if #38 is merged.
|
@Nivl which version of Django are you using? |
|
@tzangms 1.6 Why? There's something wrong with the code? |
|
Nope, I just try to add a hidden field with this line below, but I didn't see any label appear is something like this? |
|
Actually I only had the issue using modelformset_factory (sorry, I should have made that clear). Django is adding the pk field in the form as an hidden input, but for an unknown reason it displays the label. |
|
Got it, I will test that, and I should improve the example project for testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently hidden fields have their label displayed. This pull request will only display the field and not the label of an hidden element.