-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use hooks, support React 18, drop React <16 #117
Open
goto-bus-stop
wants to merge
76
commits into
default
Choose a base branch
from
hooks
base: default
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goto-bus-stop
changed the title
rewrite it with hooks
Use hooks, support React 18, drop React ≤16
Dec 18, 2021
goto-bus-stop
changed the title
Use hooks, support React 18, drop React ≤16
Use hooks, support React 18, drop React <16
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm install @u-wave/react-youtube@next
This will be version 1.0 of the library. It uses hooks internally instead of a class. It exposes a
useYouTube
hook so you can attach a player to an element that way.<YouTube />
is a very boring wrapper around that hook. The hook also provides easier access to the player instance.Breaking changes
showInfo
andsuggestedQuality
props are removed: these were already removed from the YouTube API a few years ago and have had no effect ever since.Otherwise the API remained exactly the same.
Todo