New release method for individual binary installs #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porsager
commented
Oct 25, 2024
package.json
Outdated
| @@ -8,5 +8,8 @@ | |||
| "import": "./ESM_wrapper.mjs", | |||
| "require": "./uws.js", | |||
| "types": "./index.d.ts" | |||
| }, | |||
| "optionalDependencies": { | |||
| $deps | |||
There was a problem hiding this comment.
This placeholder will be replaced with the actual single binary versions.
porsager
commented
Oct 25, 2024
uws.js
Outdated
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| module.exports = (() => { | |||
| try { | |||
| return require('./uws_' + process.platform + '_' + process.arch + '_' + process.versions.modules + '.node'); | |||
| return require('@uws/uws_' + process.platform + '_' + process.arch + '_' + process.versions.modules); | |||
There was a problem hiding this comment.
This is the new path that resolves to the specific binary installed as its own package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow for the new release.yml script to function properly. Both this PR and #1125 must be merged for everything to work right