Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the reference implementation in
systemd-analyze compare-versions
the code handling the caret character is the same as for-
and.
, right before and after:so the caret character must be treated the same in the spec as well. This is not a bug in the reference implementation, since when the sign of the comparison is inverted, i.e. caret compares higher than not-caret, the comparison
123^post1
<123.a-1
would not hold true anymore, since
^
would win against.
at step 5. This comparison must hold true, to be compatible withrpmdev-vercmp
Note:
rpmdev-vercmp
does compare123^post1
<123.a-1
, but compares^
>.
, whichsystemd-analyze
compares^
<.
This PR also adds an extended example taken from a comment of the function implementing this in systemd-analyze, which I found helpful.