Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs: mark .cmdline in UKI as optional #72

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

bluca
Copy link
Member

@bluca bluca commented Sep 9, 2023

The .cmdline section in a UKI is optional in both sd-stub and ukify, so mark it as such in the specification too

The .cmdline section in a UKI is optional in both sd-stub and ukify, so
mark it as such in the specification too
Copy link
Collaborator

@poettering poettering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migth make sense do say what it is supposed to mean when the .cmdline section is absent, and what the difference to including a .cmdline but setting it to any empty string is. (i.e. that an absent .cmdline means that the cmdline is overridable even in SecureBoot mode).

@bluca
Copy link
Member Author

bluca commented Sep 11, 2023

migth make sense do say what it is supposed to mean when the .cmdline section is absent, and what the difference to including a .cmdline but setting it to any empty string is. (i.e. that an absent .cmdline means that the cmdline is overridable even in SecureBoot mode).

Isn't that more of a sd-stub detail (that we might want to change separately)? ie it's what the loader does, rather than what the image is

@bluca bluca merged commit d62ddf0 into uapi-group:main Sep 11, 2023
1 check passed
@bluca bluca deleted the uki_cmdline branch September 11, 2023 08:40
@poettering
Copy link
Collaborator

Isn't that more of a sd-stub detail (that we might want to change separately)? ie it's what the loader does, rather than what the image is

well, sd-stub implements the logic, but I am pretty sure that the spec should dictate what sections (their presence and their absence) are supposed to mean.

@bluca
Copy link
Member Author

bluca commented Sep 11, 2023

-> #73

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants