Add emit_bc feature #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmaz
reviewed
Jul 29, 2020
| # If we're emitting a single object, we don't use an object map; we just | ||
| # declare the output file that the compiler will generate and there are | ||
| # no other partial outputs. | ||
| # If emit_bc is on, only one bitcode file is emitted |
There was a problem hiding this comment.
tried output-file-map, it doesn't seem to work with emic_bc, -### revealed it just ignore the output option and default to module-name.bc
There was a problem hiding this comment.
OK I'm missing something here
- with
num-threadson, swift will actually try to output multiple bc files, except that I can't find an option to control the output location, whatever client option I provide it just ignores it and output to the root - with single threaded wmo, it will behave like buck did, this seems intentional, I'm just gonna disable threading during bc_merge pipeline I think
There was a problem hiding this comment.
bazel exec root
so swiftc -emit-bc -wmo -num-threads 6 -output-file-map output.json a.swift b.swift-### will get you swiftc- frontend -emit-bc ... a.bc b.bc
Doesn't matter what you put in output.json
There was a problem hiding this comment.
Interesting. Pretty fine with the single object file output if that makes things easier.
rmaz
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding emit_bc feature for bc_merge pipeline
Despite different output,
emit-objectandemit-bcis largely the same in terms of input flag, etc, it's still in "compiling stage", feels like a feature flag is more fitting here rather than a new action