Test with go >= 1.18 #228
Merged
Test with go >= 1.18 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
=======================================
Coverage 47.82% 47.82%
=======================================
Files 64 64
Lines 5989 5989
=======================================
Hits 2864 2864
Misses 2685 2685
Partials 440 440 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks @vdarulis! |
shaan420
pushed a commit
that referenced
this pull request
Oct 6, 2023
shaan420
added a commit
that referenced
this pull request
Oct 6, 2023
* Set default reporting interval (#226) * Enforce minimum reporting interval * Add new RootScope constructor with default interval * Test with go >= 1.18 (#228) * add custom tags to internal metrics (#231) * add custom tags to internal metrics * make unit test stricter, update version * update version to v3.5.6 --------- Co-authored-by: Vytenis Darulis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't make sense to test with ancient Go runtimes - generics are too sweet,
and
m3db/m3is on 1.18.