Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test with go >= 1.18 #228

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Test with go >= 1.18 #228

merged 1 commit into from
Sep 28, 2023

Conversation

vdarulis
Copy link
Collaborator

Doesn't make sense to test with ancient Go runtimes - generics are too sweet,
and m3db/m3 is on 1.18.

@vdarulis vdarulis requested review from mway and prateek September 28, 2023 14:47
@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

Merging #228 (4331eb6) into master (7727a67) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #228   +/-   ##
=======================================
  Coverage   47.82%   47.82%           
=======================================
  Files          64       64           
  Lines        5989     5989           
=======================================
  Hits         2864     2864           
  Misses       2685     2685           
  Partials      440      440

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mway
Copy link
Contributor

mway commented Sep 28, 2023

Thanks @vdarulis!

@mway mway merged commit be77342 into master Sep 28, 2023
4 checks passed
@vdarulis vdarulis deleted the v/ci branch September 28, 2023 15:00
shaan420 pushed a commit that referenced this pull request Oct 6, 2023
@vdarulis @shaan420
Test with go >= 1.18 (#228)
9e0a0b8
shaan420 added a commit that referenced this pull request Oct 6, 2023
@shaan420 @vdarulis
Prepare v3.5.6 (#232)
3853e46 
* Set default reporting interval (#226)

* Enforce minimum reporting interval

* Add new RootScope constructor with default interval

* Test with go >= 1.18 (#228)

* add custom tags to internal metrics (#231)

* add custom tags to internal metrics

* make unit test stricter, update version

* update version to v3.5.6

---------

Co-authored-by: Vytenis Darulis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mway mway Awaiting requested review from mway

@prateek prateek Awaiting requested review from prateek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vdarulis @mway