add custom tags to internal metrics #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateek
reviewed
Oct 3, 2023
|
|
||
| // CommonTagsInternal are tags that should be added to all internal metrics | ||
| // emitted by the reporter. | ||
| CommonTagsInternal map[string]string `yaml:"commonTagsInternal"` |
There was a problem hiding this comment.
can you call this InternalTags or something (i just want the prefix to start with Internal to make it clear it's for internal usage)
prateek
reviewed
Oct 3, 2023
m3/reporter.go
Outdated
| @@ -288,6 +289,11 @@ func NewReporter(opts Options) (Reporter, error) { | |||
| internalTags := map[string]string{ | |||
| "version": tally.Version, | |||
| } | |||
|
|
|||
| for k, v := range opts.CommonTagsInternal { | |||
There was a problem hiding this comment.
can you ensure we don't set host/instance here too please (i think we might be inheriting those from common tags)
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
==========================================
+ Coverage 47.82% 47.85% +0.03%
==========================================
Files 64 64
Lines 5989 5993 +4
==========================================
+ Hits 2864 2868 +4
Misses 2685 2685
Partials 440 440
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shaan420
force-pushed
the
uber-go/tally/230/snair/custom-tags-internal
branch
from
0985f9e
to
a5fc9af
Compare
shaan420
added a commit
that referenced
this pull request
Oct 6, 2023
* add custom tags to internal metrics * make unit test stricter, update version
shaan420
added a commit
that referenced
this pull request
Oct 6, 2023
* Set default reporting interval (#226) * Enforce minimum reporting interval * Add new RootScope constructor with default interval * Test with go >= 1.18 (#228) * add custom tags to internal metrics (#231) * add custom tags to internal metrics * make unit test stricter, update version * update version to v3.5.6 --------- Co-authored-by: Vytenis Darulis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.