Handle missing files referenced in build files #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shYkiSto
force-pushed
the
fix-missing-file
branch
from
3085a66
to
f7ed638
Compare
shYkiSto
force-pushed
the
fix-missing-file
branch
from
f7ed638
to
56d156c
Compare
shYkiSto
changed the title
shYkiSto
changed the title
| @@ -84,15 +89,16 @@ function removeActiveChild(child) { | |||
|
|
|||
| // use exec if you need stdout as a string, or if you need to explicitly setup shell in some way (e.g. export an env var) | |||
| const exec /*: Exec */ = (cmd, opts = {}, stdio = []) => { | |||
| const errorWithSyncStackTrace = new Error(); // grab stack trace outside of promise so errors are easier to narrow down | |||
| const errorWithSyncStackTrace /*: ExecException */ = new Error(); // grab stack trace outside of promise so errors are easier to narrow down | |||
chrisdothtml
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses a scenario where removed files may still be referenced in build files. Previously,
jazelle changeswould return an empty set in such cases. The update involves reading the bazel query's stdout to utilize known labels in subsequent queries.