Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ocular-build to build dev-tools #451

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Use ocular-build to build dev-tools #451

merged 2 commits into from
Feb 21, 2024

Conversation

Pessimistress
Copy link
Collaborator

This will allow us to migrate dev-tools source to TypeScript.

ibgreen
ibgreen approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks for working through this.

I ran into blockers relating to this repo not being built with dev-tools a couple of times.

In particular when I tried to move probe.gl/test-utils here.

modules/dev-tools/package.json
"require": "./dist/index.cjs",
"import": "./src/index.js"
},
"./configuration": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat way to offer "lightweight modules"!

@Pessimistress Pessimistress merged commit cdff7b9 into master Feb 21, 2024
4 checks passed
@Pessimistress Pessimistress deleted the x/dev-tools-build branch February 21, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pessimistress @ibgreen