Begin converting to GitHub Actions #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
August 11, 2020 16:50
This reverts commit be2c2cb.
dfellis
approved these changes
Aug 18, 2020
| @@ -35,7 +35,8 @@ option(BUILD_FILTERS "Build filter applications." ON) | |||
| option(BUILD_GENERATORS "Build code generation applications." ON) | |||
|
|
|||
| if(WIN32) | |||
| set(SHELL PowerShell -Command) | |||
| # Use bash (usually from Git for Windows) for piping results | |||
| set(SHELL bash -c) | |||
There was a problem hiding this comment.
Do we know of any Windows users that can comment on this?
I know that I have bash on my Windows VM, but is that true for those who treat it as a daily driver and use git?
mrdvt92
pushed a commit
to mrdvt92/h3
that referenced
this pull request
Jun 19, 2022
Begin converting to GitHub Actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This begins moving us over to GitHub Actions for CI. We're able to remove a few of the Travis CI tests that are now run in GitHub Actions.
GitHub Actions should make it easier to test pull requests that work with compiler flags (#372, #360, #326) since the compiler installs seem to be more "standard" compared to Travis CI, which does more custom management of the compiler installs, which can result in standard "extras" missing. Also, Github Actions seems to be faster than Travis CI or Appveyor.
Not all tests are ported, this will be addressed in a later PR. The following doesn't work: