ratio for calculation of bbox area should always be > 1 (#708) #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi, could you rebase now that #711 is merged? Essentially that PR adds an if check for either diff being zero. Also, are you able to suggest some tests to validate this change? |
sebisteiner
force-pushed
the
feature/ses/bbox-estimate
branch
from
29f6310
to
4cf76d9
Compare
Done 👍 |
nrabinowitz
approved these changes
Oct 24, 2022
|
@nrabinowitz I made two errors in my unit test 😢 Will fix it later today. |
|
@nrabinowitz Done. Sorry for the inconvenience. |
nrabinowitz
reviewed
Oct 25, 2022
nrabinowitz
reviewed
Oct 25, 2022
Co-authored-by: Nick Rabinowitz <[email protected]>
isaacbrodsky
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and discussion is here: #708