Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternate polygonToCells algorithm #785

Merged
merged 47 commits into from
Oct 31, 2023
Merged

Alternate polygonToCells algorithm #785

merged 47 commits into from
Oct 31, 2023

Commits on Oct 25, 2023

  1. Add scaleBBox, with tests

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    f72cbc2 View commit details
    Browse the repository at this point in the history

  2. Add cellToChildBBox with tests

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    8a27b2a View commit details
    Browse the repository at this point in the history

  3. Cleanup

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    5bc92fc View commit details
    Browse the repository at this point in the history

  4. Implement bboxIntersects, with tests

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    0a856f2 View commit details
    Browse the repository at this point in the history

  5. Add lineIntersectsLine, with tests

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    42a1ea6 View commit details
    Browse the repository at this point in the history

  6. Implement cellBoundaryInsidePolygon

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    ec1a6f6 View commit details
    Browse the repository at this point in the history

  7. Tests and fixes for cellBoundaryCrossesGeoLoop

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    34ba399 View commit details
    Browse the repository at this point in the history

  8. First pass at polyfill algo, untested

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    5f6ede9 View commit details
    Browse the repository at this point in the history

  9. Use const polygon

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    cc6a060 View commit details
    Browse the repository at this point in the history

  10. Fixed several issues, most tests passing

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    0ec7869 View commit details
    Browse the repository at this point in the history

  11. Fix transmeridian handling

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    793f46e View commit details
    Browse the repository at this point in the history

  12. Comment fix

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    9eaee77 View commit details
    Browse the repository at this point in the history

  13. Working uncompact with wrapping iterator

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    519b0b4 View commit details
    Browse the repository at this point in the history

  14. Small optimization: Normalize BBox outside loop

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    37243fe View commit details
    Browse the repository at this point in the history

  15. Small optimization, reference cell boundary instead of copy

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    d720d3a View commit details
    Browse the repository at this point in the history

  16. Small optimization: Update child iterator in place

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    10667cc View commit details
    Browse the repository at this point in the history

  17. Implement polygonToCellsCompact

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    0caf37d View commit details
    Browse the repository at this point in the history

  18. Fix missing file in CMake

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    9389945 View commit details
    Browse the repository at this point in the history

  19. free bboxes, come and get 'em

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    19aa9ca View commit details
    Browse the repository at this point in the history

  20. format

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    ed3b143 View commit details
    Browse the repository at this point in the history

  21. Copyright fix 

    Co-authored-by: Isaac Brodsky <[email protected]>
    @nrabinowitz @isaacbrodsky
    2 people authored and Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    135e5a3 View commit details
    Browse the repository at this point in the history

  22. comment fix 

    Co-authored-by: Isaac Brodsky <[email protected]>
    @nrabinowitz @isaacbrodsky
    2 people authored and Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    1380aeb View commit details
    Browse the repository at this point in the history

  23. copyright fix 

    Co-authored-by: Isaac Brodsky <[email protected]>
    @nrabinowitz @isaacbrodsky
    2 people authored and Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    3cbcafc View commit details
    Browse the repository at this point in the history

  24. comment fix 

    Co-authored-by: Isaac Brodsky <[email protected]>
    @nrabinowitz @isaacbrodsky
    2 people authored and Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    a1758fe View commit details
    Browse the repository at this point in the history

  25. Fix error declaration and division by zero

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    6dd99ad View commit details
    Browse the repository at this point in the history

  26. Micro-optimizations: faster cellToParent, bbox check on line intersec… 

    …tion
    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    b9c4358 View commit details
    Browse the repository at this point in the history

  27. Fix transmeridian bbox checks

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    216500a View commit details
    Browse the repository at this point in the history

  28. Intersects -> overlaps, cheap checks for poles and bbox containment

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    77a13fb View commit details
    Browse the repository at this point in the history

  29. Simplify bboxOverlapsBBox

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    0866771 View commit details
    Browse the repository at this point in the history

  30. Remove old polyfill algo, update tests

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    29fc0e9 View commit details
    Browse the repository at this point in the history

  31. Update CHANGELOG

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    e15845e View commit details
    Browse the repository at this point in the history

  32. Add test coverage

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    8cef837 View commit details
    Browse the repository at this point in the history

  33. Restore old algo, rename new to polygonToCellsExperimental

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    eef2bc5 View commit details
    Browse the repository at this point in the history

  34. First pass at faster cellToBBox

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    aa2990b View commit details
    Browse the repository at this point in the history

  35. Update scale factor

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    47e1d23 View commit details
    Browse the repository at this point in the history

  36. Use a lookup table for res0 bounding boxes

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    b63921b View commit details
    Browse the repository at this point in the history

  37. Add test coverage

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    dad85b0 View commit details
    Browse the repository at this point in the history

  38. Copy tests for testPolygonToCellsReported

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    3fe75a7 View commit details
    Browse the repository at this point in the history

  39. Re-add test for uncovered lines

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    475d8f6 View commit details
    Browse the repository at this point in the history

  40. Restore simpler NORMALIZE_LNG macro for point-in-poly

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    c3c206d View commit details
    Browse the repository at this point in the history

  41. Use switch-based function for normalizeLng

    Nick Rabinowitz committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    862dd86 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Move normalizeLng to latlng, fix tests

    Nick Rabinowitz committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    6c55f50 View commit details
    Browse the repository at this point in the history

  2. Add separate benchmark for new polyfill

    Nick Rabinowitz committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    b774725 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Fix switch to always return

    Nick Rabinowitz committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    5453092 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Update and tests for baseCellNumToCell

    Nick Rabinowitz committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    8652b4e View commit details
    Browse the repository at this point in the history

  2. Drop dupe tests, malloc -> calloc

    Nick Rabinowitz committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    6b94307 View commit details
    Browse the repository at this point in the history

  3. Fix calloc

    Nick Rabinowitz committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    6f0a122 View commit details
    Browse the repository at this point in the history