Remove very old pickle compatibility code modifying old atg package names#702
Open
selitvin wants to merge 3 commits intouber:masterfrom
Open
Remove very old pickle compatibility code modifying old atg package names#702selitvin wants to merge 3 commits intouber:masterfrom
selitvin wants to merge 3 commits intouber:masterfrom
Conversation
chongxiaoc
approved these changes
Jul 26, 2021
bbd0d5e to
c0d5337
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #702 +/- ##
=======================================
Coverage 86.27% 86.27%
=======================================
Files 85 85
Lines 5084 5070 -14
Branches 787 784 -3
=======================================
- Hits 4386 4374 -12
+ Misses 559 558 -1
+ Partials 139 138 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0eee866 to
8ca9df8
Compare
added 2 commits
April 13, 2022 21:37
…ames The code was meant to support opening some old datasets that contained pickled data with pre-petastorm names.
It was removed by mistake. The test actually tests an ability to read a dataset created with previous version of petastorm.
16de47f to
513533b
Compare
|
Yevgeni Litvin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is code cleanup. The code was meant to support opening some old datasets that contained pickled data with pre-petastorm names.
Can not specify
selitvin:selitvin/remove_legacyas an upstream, so github shows two commits in this PR. Please review only the second commit as the first is part of #640