Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#64
i added back in the logic for my original thoughts on incorporating zscore w/ luck. this is definitely a WIP, so feedback is needed to figure out what there right course of action is.
the biggest updates were updating the luck/matchup metric function with EVEN MORE stuff (because the best functions do more than 1 thing) but from there, zscore is available on a weekly basis. i tried to work around the missing week 1/2 zscore problem by returning 0's for things, but there is probably some cleanup needed.
i added them to the reports so you can see and compare them, added subtitle text to explain how they are calculated ( might only make sense to you and me) and we can adapt/advance what those are, remove them, etc. there is at least 1 improvement remaining that i didnt take the time to do and thats replace the original zscore calculations and the check if it needs to be added to report with the zscore that is calculated as part of the weekly metrics, i just got lazy tbh, if this has legs then i can go back and update that.
something that is probably worthy of a bigger refactor is how much of a pain it was to find all the places in the code i needed to tweak so it was aware of my new metric(s). i was hoping adding a table to the report would be fairly simple, but there are a bunch of places where i need to go in to functions that are seemingly innocuous but are knowledgable and checking for specific types of things to do stuff. im not sure exactly how to fix it without it being a whole thing, so i just went along with existing setup, but i was stuck for a while on how to add a new table that had different data than the original luck, but the table headers objects are weird and keep data about previous tables created for them, maybe its just a pdf generator issue.