Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add more luck metrics #69

Closed
wants to merge 2 commits into from

Conversation

ragnarok56
Copy link
Collaborator

#64

i added back in the logic for my original thoughts on incorporating zscore w/ luck. this is definitely a WIP, so feedback is needed to figure out what there right course of action is.

the biggest updates were updating the luck/matchup metric function with EVEN MORE stuff (because the best functions do more than 1 thing) but from there, zscore is available on a weekly basis. i tried to work around the missing week 1/2 zscore problem by returning 0's for things, but there is probably some cleanup needed.

i added them to the reports so you can see and compare them, added subtitle text to explain how they are calculated ( might only make sense to you and me) and we can adapt/advance what those are, remove them, etc. there is at least 1 improvement remaining that i didnt take the time to do and thats replace the original zscore calculations and the check if it needs to be added to report with the zscore that is calculated as part of the weekly metrics, i just got lazy tbh, if this has legs then i can go back and update that.

something that is probably worthy of a bigger refactor is how much of a pain it was to find all the places in the code i needed to tweak so it was aware of my new metric(s). i was hoping adding a table to the report would be fairly simple, but there are a bunch of places where i need to go in to functions that are seemingly innocuous but are knowledgable and checking for specific types of things to do stuff. im not sure exactly how to fix it without it being a whole thing, so i just went along with existing setup, but i was stuck for a while on how to add a new table that had different data than the original luck, but the table headers objects are weird and keep data about previous tables created for them, maybe its just a pdf generator issue.

Kevin Nacios added 2 commits October 27, 2019 22:57
show in report
highlights how intertwined specific metrics are with the rest of the project
@uberfastman uberfastman added this to the App Metrics milestone Oct 2, 2020
@uberfastman uberfastman added feature request New feature or request improvement Improvement to existing feature or functionality labels Oct 6, 2020
@uberfastman uberfastman deleted the branch uberfastman:develop October 20, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request improvement Improvement to existing feature or functionality
Development

Successfully merging this pull request may close these issues.

2 participants