You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I expected that by providing an id and a label the label points to the input and not the div above.
Actual results
Instead of '...', what I saw was that '...' happened instead.
Reproduction steps
Provide a id and a label
Check the label for and id of the input and they don't match
Additional Information
This poses an accessibility problem which basically right now its very hard to solve as we don't have access to the internals. the only way is to add the label ourselves.. Also the documentation is wrong here https://github.com/ubilabs/react-geosuggest#label since this is not what happens currently
The text was updated successfully, but these errors were encountered:
Short description
I was trying to add a label that points correctly to the id of the input.
In this issue #450 there is a mention to this PR #464 which implements a id to the input, however the "for" attribute of the label points to the id prop directly and the input has a id of
geosuggest__input--${id}
https://github.com/ubilabs/react-geosuggest/pull/464/files#diff-c4990fe56ebfd0fcaf879109aa33c1a0002f567e3273ec7255e94934331cbbd6R169 which basically now has the label pointing to the div that wraps the entire autocomplete instead of pointing to the input itself.Expected results
I expected that by providing an id and a label the label points to the input and not the div above.
Actual results
Instead of '...', what I saw was that '...' happened instead.
Reproduction steps
Additional Information
This poses an accessibility problem which basically right now its very hard to solve as we don't have access to the internals. the only way is to add the label ourselves.. Also the documentation is wrong here https://github.com/ubilabs/react-geosuggest#label since this is not what happens currently
The text was updated successfully, but these errors were encountered: