-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Geosuggest): fix input id and label for #491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your pull request!
Just two small things.
Will look into these today, sorry was away for vacation but happy to continue the work here |
Co-authored-by: Leslie Lawendel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing 🙂
Co-authored-by: Leslie Lawendel <[email protected]>
Any chance that this gets merged? I would love to have this fix and do an update on our end ;) thanks! if not on #511 then on the next on maybe |
Description
Fixes
#490
Right now the label and id input do not work as its explained in the documentation and also how one would probably expect (the label "for" attribute would link to the input "id" :
In the readme section :
However what happens currently is this :
With this PR the label for and input id will match. a test was also included to insure this stays as expected in the future
Note : I do understand this could potentially break people's end to end tests which is actually how I found otu the issue myself trying to upgrade to the latest version, because this was already changed as previously the input id was the props.id directly (which is what I would expect)- This technically could be considered a breaking change, but a breaking change was already then made in #464 so I guess here is not really anything new.
Checklist