expose typescript type definitions #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro-ka
reviewed
Oct 19, 2018
| lat: number; | ||
| lng: number; | ||
| }; | ||
| readonly gmaps?: google.maps.GeocoderResult; |
There was a problem hiding this comment.
We need to include this, too. It’s available and shouldn’t be removed.
| @@ -25,18 +24,18 @@ export default interface IProps { | |||
| readonly queryDelay?: number; | |||
| readonly googleMaps?: any; | |||
| readonly highlightMatch?: boolean; | |||
| readonly onSuggestSelect?: (suggest?: ILocation) => void; | |||
There was a problem hiding this comment.
I’m unsure about this change — the suggest provided on select may only consist of the location and the optional Google Maps result.
|
There were some small changes to the |
4 tasks
|
Closing this due to inactivity. Opened an issue for this: #467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
interface-nameeslint rule to"never-prefix"so exposed TS interfaces don't have to begin with a prefix ofI.gmapsproperty to theSuggestinterface (it was being left out before).PropstoGeosuggestPropsfor clarity.Checklist