Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Patch location, radius, bounds, and adding locationBias and locationrestriction #498

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

imdbsd
Copy link

@imdbsd imdbsd commented Jun 8, 2023

Description

Patch deprecation notice from google place api #497

Checklist

  • All tests passing
  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary
  • Commits and PR follow conventions

@imdbsd imdbsd changed the title Refactor/patch deprecated fields refactor: Patch location, radius, bounds, and adding locationBias and locationrestriction Jun 8, 2023
@imdbsd
Copy link
Author

imdbsd commented Jun 8, 2023

Hi, im trying to patching this future deprecation field from google place api. Would like to hear a feedback if this should be a breaking change by removing the props (location, radius and bounds) or it can be still there with newer approach to pass it to the locationBias

@speedy250
Copy link

This would be great to get merged in so the locationBias attribute can be used!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants