Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/module types #507

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Feat/module types #507

merged 3 commits into from
Aug 8, 2023

Conversation

plumdumpling
Copy link
Contributor

Description

  • rename interfaces
  • use named exports for types (for named exports in npm module)
  • add ts declaration file to npm module

Checklist

  • All tests passing
  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary
  • Commits and PR follow conventions

@plumdumpling plumdumpling requested a review from yfr August 8, 2023 07:38
yfr
yfr approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@yfr yfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we need a new major release because of the types renaming. Or is this not relevant?

@plumdumpling
Copy link
Contributor Author

Does this mean we need a new major release because of the types renaming. Or is this not relevant?

I would say it's not relevant, because we didn't export the types before.

@plumdumpling plumdumpling merged commit 66d90fe into main Aug 8, 2023
1 check passed
@plumdumpling plumdumpling deleted the feat/module-types branch August 8, 2023 09:12
@plumdumpling plumdumpling linked an issue Aug 9, 2023 that may be closed by this pull request
Expose TypeScript type definitions #467
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfr yfr yfr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose TypeScript type definitions
2 participants
@plumdumpling @yfr