Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/highlight matched substrings #509

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Fix/highlight matched substrings #509

merged 3 commits into from
Oct 2, 2023

Conversation

plumdumpling
Copy link
Contributor

Description

close #396

  • highlight all matches coming from the Google API
  • find matched substrings in fixtures case insensitive
  • add test for multiple matched substrings

Checklist

  • All tests passing
  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary
  • Commits and PR follow conventions

@plumdumpling plumdumpling requested a review from yfr August 9, 2023 12:04
@plumdumpling plumdumpling merged commit f3cb836 into main Oct 2, 2023
1 check passed
@plumdumpling plumdumpling deleted the fix/highlight-matched-substrings branch October 2, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfr yfr yfr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlighting of matched text doesn't work as expected.
2 participants
@plumdumpling @yfr