Responsive fix #309
Responsive fix #309
Conversation
|
The is the latest iteration. I got carried away with he previous version and completely didn't notice the align ment issue so I had to go for another approach with media queries. The table body width is 565px max. On bigger screens we can increase the anchor length as long as it doesn't overflow the table body container. On small screens however, the green width is usually below 565px therefore the table will assume view width size. The parent element , td#recipient, of the anchor tag is 80% of the table body width. Taking 80% of 80 leaves us with 64% of view width. |
|
Thank you for the fix. It looks fine to me but I'll give it a run with my eth domain and Windows machine tomorrow to be sure. |
|
You're welcome :-)
…On Sun, 15 Sep 2024, 10:56 Mentlegen, ***@***.***> wrote:
Thank you for the fix. It looks fine to me but I'll give it a run with my
eth domain and Windows machine tomorrow to be sure.
—
Reply to this email directly, view it on GitHub
<#309 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A7M52G6JPSPJPJ5GKBDE42TZWVKUHAVCNFSM6AAAAABOHUNCHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJRGUYDOMRXG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Have you checked it yet?? |
|
This is what I see: I am not sure if that's right, rfc @0x4007 |
|
Overflow hidden and text overflow ellipse |
|
Is that even possible. I took out the scroll bar earlier. |
|
@0x4007 this doesn't seem to have the latest changes. I thinks it's from the branch I deleted earlier to start this one. You can see the misalignment of the amount and the address, which was why the previous iteration had to be rejected and reworked on. @gentlementlegen Please load the latest changes. |
|
The old branch was still linked to my remote, my bad. Here are the updated screenshots: Seems to work fine so far. |
| #rewardRecipient > a { | ||
| display: inline-block; | ||
| width: 100%; | ||
| max-width: calc(0.7*565px); |
There was a problem hiding this comment.
What is the significance of 0.7 and 565?
There was a problem hiding this comment.
The table body width is 565px max. On bigger screens we can increase the anchor length as long as it doesn't overflow the table body container.
On small screens however, the green width is usually below 565px therefore the table will assume view width size. The parent element , td#recipient, of the anchor tag is 80% of the table body width. Taking 80% of 80 leaves us with 64% of view width.
There was a problem hiding this comment.
That's the most optimal value
There was a problem hiding this comment.
Taking 80% of 80 leaves us with 64% of view width.
There's nothing about 70% in your explanation
Co-authored-by: アレクサンダー.eth <[email protected]>
Anticipating the merge |
|
@CaptainPrinz can you resolve the conflicts please |
|
@Keyrxng conflicts resolved |
|
@0x4007 Good to go here? |
|
@Keyrxng please merge and fund |
Resolves #237