Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mint gift card with ubiquity dollars #313

Merged
merged 6 commits into from
Oct 5, 2024
Merged

feat: mint gift card with ubiquity dollars #313

merged 6 commits into from
Oct 5, 2024

Conversation

whilefoo
Copy link
Contributor

@whilefoo whilefoo commented Sep 22, 2024 •
edited
Loading

Resolves #267

image

image

image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 22, 2024 •
edited
Loading

Unused dependencies (1)

Filename dependencies
package.json zod

0x4007
0x4007 requested changes Sep 24, 2024
View reviewed changes
functions/helpers.ts Outdated Show resolved Hide resolved
functions/helpers.ts Outdated Show resolved Hide resolved
functions/post-order.ts Show resolved Hide resolved
functions/post-order.ts Show resolved Hide resolved
shared/constants.ts Outdated Show resolved Hide resolved
static/scripts/ubiquity-dollar/init.ts Outdated Show resolved Hide resolved
static/ubiquity-dollar.html Outdated Show resolved Hide resolved
@rndquu rndquu mentioned this pull request Sep 27, 2024
Closed
@whilefoo
Copy link
Contributor Author

whilefoo commented Oct 4, 2024

Are we fine with merging this?

@0x4007
Copy link
Member

0x4007 commented Oct 5, 2024 •
edited
Loading

Can you fix zod knip

@0x4007 0x4007 merged commit 31674ad into ubiquity:beta Oct 5, 2024
2 of 3 checks passed
@whilefoo
Copy link
Contributor Author

whilefoo commented Oct 5, 2024

Can you fix zod knip

Actually I'm not sure why it's marked as unused dependency because it is used

@0x4007
Copy link
Member

0x4007 commented Oct 5, 2024

You can ignore the warning by tweaking the config worst case scenario.

@rndquu rndquu mentioned this pull request Oct 9, 2024
Closed
@0x4007 0x4007 linked an issue Oct 9, 2024 that may be closed by this pull request
Mint card for Ubiquity Dollars #267
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EresDev EresDev EresDev left review comments

@rndquu rndquu rndquu left review comments

@0x4007 0x4007 0x4007 approved these changes

@Keyrxng Keyrxng Awaiting requested review from Keyrxng Keyrxng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mint card for Ubiquity Dollars
4 participants
@whilefoo @0x4007 @EresDev @rndquu