-
Notifications
You must be signed in to change notification settings - Fork 16
feat(performance): bundle performance split – reduce main chunk by 43% #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
3scava1i3r
wants to merge
4
commits into
ubiquity:development
Choose a base branch
from
3scava1i3r:bundle-performance
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # Bundle Performance Split Report | ||
|
|
||
| ## Report (fill in) | ||
|
|
||
| Before: main chunk gzip size ≈ 168 kB (from prior build). | ||
| After: main chunk gzip size ≈ 96 kB. | ||
|
|
||
| ## Notes | ||
|
|
||
| ### Changes Made | ||
|
|
||
| 1. **Vite Configuration** (`vite.config.ts`): | ||
| - Added `manualChunks` function-based configuration to properly split vendor libraries | ||
| - Created separate chunks for: `vendor-react`, `vendor-query`, `vendor-wallet` | ||
| - Used function approach to correctly identify React/ReactDOM modules | ||
|
|
||
| 2. **Component Lazy Loading** (`src/components/dashboard-page.tsx`): | ||
| - Lazy loaded `ConnectWalletButton` with `Suspense` | ||
| - Added skeleton fallback for wallet button | ||
|
|
||
| ### Build Results | ||
|
|
||
| | Chunk | Size (gzip) | Notes | | ||
| |-------|-------------|-------| | ||
| | Main app chunk | ~96 kB | Reduced from ~168 kB ✅ | | ||
| | vendor-react | ~60.54 kB | React + React DOM (properly sized now) | | ||
| | vendor-query | ~10.44 kB | React Query | | ||
| | vendor-wallet | ~980.36 kB | Still large due to wallet libs | | ||
|
|
||
| ### Acceptance Criteria | ||
|
|
||
| - ✅ Main application chunk gzip size reduced meaningfully (< 140 kB target met) | ||
| - ✅ App builds successfully (`bun run build`) | ||
| - ✅ App runs with dev server (`bun run dev`) | ||
| - ✅ No broken dynamic imports (lazy loading working) | ||
|
|
||
| ### Remaining Optimizations (Future) | ||
|
|
||
| The `vendor-wallet` chunk is still very large (~980 kB gzipped) due to the heavy wallet libraries (wagmi, viem, appkit, coinbase sdk, metamask sdk). Further optimization opportunities: | ||
| - Consider lazy loading the entire wallet provider context | ||
| - Split wallet connectors (MetaMask, WalletConnect, Coinbase) into separate chunks | ||
| - Use dynamic imports for rarely-used wallet features | ||
| - Potentially remove unused wallet SDKs if not needed | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.