Change RepositoryMock GetCommits(GetCommitsRequest request) to sort commits like the GitLab api #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of
NGitLab.Mock.RepositoryGetCommits(GetCommitsRequest request)is different fromGetCommits(string @ref)GetCommits(string @ref)correctly returns commits in reverse chronological order (newest commit first).https://docs.gitlab.com/api/commits/#list-repository-commits
GetCommits(GetCommitsRequest request)does not:The GitLab api returns commits like
GetCommits(string @ref)I assume this is because of the difference in the
SortByused inside.This might break existing tests that assume this behavior. But aligning the behavior with GitLab itself justifies this, imo.
https://docs.gitlab.com/api/commits/#list-repository-commits
