You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request contains four small-ish fixes/improvements:
Improve the documentation clarity in the main README.md
Allow specifying lowercase log levels via UBLUE_LOG to match the behavior of most other tools
Cleanup the config file loading logic, and avoid crashes when not all config options are specified.
Add a --config CLI option to allow alternate config files when testing
...as well as two new features related to the update precondition checks (these two were the main driver for this pull request):
Add a network_not_metered check to prevent downloading multiple GB of data when on metered/mobile connections
(the latter of which happened to me while using my smartphone as a hotspot).
This check should probably be enabled in all environments where NetworkManager is supported, to avoid annoying surprises on mobile data plans. It is currently disabled by default, though, to not break any existing installations.
Add a facility for using fully custom scripts to check for additional preconditions.
My personal rationale for this is that I want to be able to prevent unnecessary background work when using my laptop for a DJ set, to avoid stutter. I'm not sure yet whether I want to use a manual settings toggle or automatic detection of the DJ software for this, but implementing it in a flexible manner allows me and other to solve these usecases without bloating up the ublue_update code too much.
thanks so much for the PR! And thanks for giving this project some much needed love. LGTM, looks like it needs some formatting changes though. Sorry for the late reply, I've been pretty busy lately
thanks so much for the PR! And thanks for giving this project some much needed love. LGTM, looks like it needs some formatting changes though. Sorry for the late reply, I've been pretty busy lately
You're welcome! This resolves one of the (actually very few) hiccups I've discovered after switching to Bluefin, so I'm happy to make a great idea like Bluefin just a tiny bit greater.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cr7pt0gr4ph7
force-pushed
the
custom-preconditions
branch
from
This pull request contains four small-ish fixes/improvements:
UBLUE_LOGto match the behavior of most other tools--configCLI option to allow alternate config files when testing...as well as two new features related to the update precondition checks (these two were the main driver for this pull request):
Add a
network_not_meteredcheck to prevent downloading multiple GB of data when on metered/mobile connections(the latter of which happened to me while using my smartphone as a hotspot).
This check should probably be enabled in all environments where NetworkManager is supported, to avoid annoying surprises on mobile data plans. It is currently disabled by default, though, to not break any existing installations.
Add a facility for using fully custom scripts to check for additional preconditions.
My personal rationale for this is that I want to be able to prevent unnecessary background work when using my laptop for a DJ set, to avoid stutter. I'm not sure yet whether I want to use a manual settings toggle or automatic detection of the DJ software for this, but implementing it in a flexible manner allows me and other to solve these usecases without bloating up the
ublue_updatecode too much.Fixes #115