Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto sign images #73

Merged
merged 12 commits into from
Sep 22, 2023
Merged

feat: auto sign images #73

merged 12 commits into from
Sep 22, 2023

Conversation

gerblesh
Copy link
Collaborator

@gerblesh gerblesh commented Sep 21, 2023

what's in this PR:

  • automatic image signing by getting metadata from /usr/share/ublue-os/image-info.json
  • error handling when running rpm-ostree commands, now ublue-update can be ran from a container without errors
    We also need to talk with downstream, but ublue-update still works without that metadata file, and only uses it if it's there, so compatability isn't broken

@gerblesh
Copy link
Collaborator Author

more info on how to implement this spec, basically you need to define two variables in JSON:

{
"image-ref": "ostree-image-signed:docker://ghcr.io/ublue-os/bazzite-deck",
"default-image-tag": "latest"
}

put this file in /usr/share/ublue-os/image-info.json

Copy link
Member

@EyeCantCU EyeCantCU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, this is going to make the process leaps and bounds better!

This will change when/if the user rebases to a new tag
@KyleGospo
Copy link
Member

Huge fan of this, thank you!

@gerblesh gerblesh marked this pull request as ready for review September 22, 2023 19:02
@gerblesh gerblesh merged commit 6acce45 into main Sep 22, 2023
3 checks passed
@gerblesh gerblesh deleted the auto-sign-image branch September 22, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants