-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto sign images #73
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more info on how to implement this spec, basically you need to define two variables in JSON: {
"image-ref": "ostree-image-signed:docker://ghcr.io/ublue-os/bazzite-deck",
"default-image-tag": "latest"
} put this file in |
…pdate into auto-sign-image
If the image reference file doesn't exist, we don't need to check the local image reference
EyeCantCU
force-pushed
the
auto-sign-image
branch
from
September 22, 2023 15:22
d7c5e06
to
3b2bcc7
Compare
Adheres to formatting reqs
EyeCantCU
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, this is going to make the process leaps and bounds better!
This will change when/if the user rebases to a new tag
Huge fan of this, thank you! |
KyleGospo
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what's in this PR:
ublue-update
can be ran from a container without errorsWe also need to talk with downstream, but
ublue-update
still works without that metadata file, and only uses it if it's there, so compatability isn't broken