test(canon): regenerate ecosystem-products canon snapshot for static prop value checks#3199
Closed
ubugeeei wants to merge 1 commit into
Closed
test(canon): regenerate ecosystem-products canon snapshot for static prop value checks#3199ubugeeei wants to merge 1 commit into
ubugeeei wants to merge 1 commit into
Conversation
…prop value checks The static-attribute prop type-checking change in #3197 makes vize check emit per-prop assertions for static attribute values, but the ecosystem-products check snapshot was not regenerated, so the vue-parity job fails on the stale `virtualTs` fields. Regenerate the snapshot. The diff is purely additive per-prop check lines (`const __vize_prop_check_N_*` plus their type aliases and source maps) for static values; diagnostics, errorCount (2), warningCount (0), and fileCount (6) are unchanged, confirming no new type errors. Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
github-actions
Bot
changed the title
vize
@vizejs/fresco
@vizejs/musea-mcp-server
oxlint-plugin-vize
@vizejs/rspack-plugin
@vizejs/unplugin
@vizejs/vite-plugin
@vizejs/vite-plugin-musea
@vizejs/musea-nuxt
@vizejs/nuxt
@vizeui/core
commit: |
Contributor
PR BenchmarkBase:
Raw run timesCompile SFC
Lint
Format
Type check (1T)
Type check (max)
|
Contributor
Detailed Test ReportCommit: Area Summary
Test InventoryTotal tracked cases: 9469 across 1464 files.
Files
Comment truncated at 64000 characters. Open the workflow run for the full job log. |
Collaborator
Author
|
Superseded by #3200, which merged the byte-identical snapshot refresh (this branch now has a zero diff against main). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The static-attribute prop type-checking change from #3197 was merged into
main, but itsvize check --show-virtual-tssnapshot for theecosystem-productsfixture was never regenerated. As a result thevue-parityjob now fails onmainwith a snapshot mismatch:The mismatch is limited to the
virtualTsfields of the 5 fixture files that pass static attribute values to child components.What
Regenerates
ecosystem-products-check.snapwith the current binary. The change is purely additive: the new per-prop assertions vize now emits for static attribute values, e.g.diagnosticsper file,errorCount(2),warningCount(0), andfileCount(6) are all unchanged, confirming the newly-checked static values type-check cleanly and introduce no new false positives. Only the recorded generated TypeScript grew.Follow-up to #3197.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is enabled.